Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only initialize graal JS context when required. Fixes #1723 #1725

Merged
merged 1 commit into from
May 22, 2024

Conversation

johnaohara
Copy link
Member

Fixes Issue

Fixes: #1723

In the flamegraphs below, calls to Util.setupContext() are highlighted

Before;

image

After ;

image

@johnaohara johnaohara self-assigned this May 22, 2024
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnaohara johnaohara merged commit 88cc42e into Hyperfoil:master May 22, 2024
4 checks passed
@johnaohara johnaohara deleted the issue_1723 branch May 22, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Graal JS context is initialized for every datapoint calculation, regardless if it is required
2 participants